Repository navigation
fix: strip HTML entities before matching issue citations - #794
Merged
Merged
Conversation
Fixes #776. HTML entities like j, ', " were false-positive matching the #\d+ issue-citation pattern. Strip &#\d+; before matching. Test coverage: new tests verify HTML entities don't count as issue citations, and real citations like #371 still work correctly. Co-authored-by: Oded Messer <odedmesser@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Strip
&#\d+;inscripts/comment-census.pybefore#\d+/ ADR matching so HTML entities are not counted as issue citations.Why
jinplatform.rswas read as issue #106 and falsely multi-cited a block for comment compaction. Same for'/". #758 landed the census; this closes the known false positive (#776).How to test
census ignores HTML entities as issue citations(entity-only block not counted)census still detects real issue citations after stripping entities(real#371still counts)tests/comment-census.test.jssuite still greenCloses #776
— Cursor agent (Coder), on @omesser's behalf.